forked from JSKitty/scc-web3
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v1.3.0 + Update Changelog #223
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSKitty
added
Documentation
Improvements or additions to documentation
Enhancement
New feature or request
labels
Oct 7, 2023
JSKitty
requested review from
Luke-Larsen,
panleone,
Liquid369,
Duddino,
PalmTreeVI,
BreadJS and
a team
October 7, 2023 15:12
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JSKitty
added
Awaiting Review
This PR and/or issue is awaiting reviews before continuing.
Review Reward: 20 PIV
Reviewers of this Pull Request will receive a 20 PIV reward
labels
Oct 7, 2023
Co-authored-by: Valerio Laera <[email protected]>
- Fix createTransaction return type - Fix a bug where you couldn't redeem promo codes
* Fix ledger error * lowercase * Remove console.log
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Awaiting Review
This PR and/or issue is awaiting reviews before continuing.
Documentation
Improvements or additions to documentation
Enhancement
New feature or request
Review Reward: 20 PIV
Reviewers of this Pull Request will receive a 20 PIV reward
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR is in preparation for the v1.3.0 release:
npm audit fix
was ran to fix1 moderate severity vulnerability
stemming fromnanoid
.Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
This is just a few hours before the release of v1.3.0, so if there's a good time to catch last-minute bugs, that time is NOW! 💜
If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!